On 26/03/26 7:12 PM, Surya Kumari Jangala wrote:
Hi Vijay,
You can test this patch on a big-endian Linux machine. AIX is a big endian
operating system, so testing this patch on a big-endian Linux system should
be helpful.

-Surya

Hello,

That may not work since the patterns related to aix (Guarded by TARGET_XCOFF) wont be touched, I tried to build a cross compiler but im having issues with build.

Thanks,
Vijay.

On 25/03/26 2:42 PM, Vijay Telidevulapalli wrote:
Hello,

Gentle ping for review.

I have not tested this on AIX or added a dedicated test case for it.
Please let me know if AIX testing or additional test coverage is required.

Thank you,
Vijay Shankar

On 16/03/26 2:30 PM, Vijay Shankar wrote:
POWER10 has instruction fusion for addis+addi pairs.
However, the scheduler was breaking these pairs apart to optimize for
dependency chains, losing the fusion benefit.

This patch implements "fake" instructions that represent both
instructions as a single pattern. This prevents the scheduler from
reordering them while still generating the correct two-instruction
sequence.

Existing high/low patterns are guarded with !TARGET_POWER10 to
prevent conflicts with the new fusion patterns.

Existing high/low patterns are guarded with !TARGET_POWER10 to prevent
conflicts with the new fusion patterns.

Bootstrapped and tested on powerpc64le-linux-gnu with no regressions.

2026-03-16  Vijay Shankar  <[email protected]>

gcc/ChangeLog:
     PR target/108018
     * config/rs6000/rs6000.md (*largetoc_high): Add !TARGET_POWER10
     guard.
     (*largetoc_high_aix<mode>): Likewise.
     (*largetoc_high_plus): Likewise.
     (*largetoc_high_plus_aix<mode>): Likewise.
     (*largetoc_low): Likewise.
     (*largetoc_low_aix<mode>): Likewise.
     (*largetocp10_high_low_aix<mode>): New pattern for POWER10
     wide-immediate fusion.
     (*largetocp10_high_low_plus_aix<mode>): Likewise.
     (*largetocp10_high_low): Likewise.
     (*largetocp10_high_low_plus): Likewise.
     (*tocref<mode>): Add !TARGET_POWER10 guard.

gcc/testsuite/ChangeLog:
     PR target/108018
     * gcc.target/powerpc/pr108018-1.c: New test for POWER10 fusion.
---
   gcc/config/rs6000/rs6000.md                   | 64 +++++++++++++++++--
   gcc/testsuite/gcc.target/powerpc/pr108018-1.c | 14 ++++
   2 files changed, 71 insertions(+), 7 deletions(-)
   create mode 100644 gcc/testsuite/gcc.target/powerpc/pr108018-1.c

diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md
index 308955155..cba6ff3d4 100644
--- a/gcc/config/rs6000/rs6000.md
+++ b/gcc/config/rs6000/rs6000.md
@@ -11283,7 +11283,8 @@
         (unspec [(match_operand:DI 1 "" "")
              (match_operand:DI 2 "gpc_reg_operand" "b")]
             UNSPEC_TOCREL)))]
-   "TARGET_ELF && TARGET_CMODEL != CMODEL_SMALL"
+   "TARGET_ELF && TARGET_CMODEL != CMODEL_SMALL
+   && !TARGET_POWER10"
      "addis %0,%2,%1@toc@ha")
     (define_insn "*largetoc_high_aix<mode>"
@@ -11292,7 +11293,8 @@
         (unspec [(match_operand:P 1 "" "")
              (match_operand:P 2 "gpc_reg_operand" "b")]
             UNSPEC_TOCREL)))]
-   "TARGET_XCOFF && TARGET_CMODEL != CMODEL_SMALL"
+   "TARGET_XCOFF && TARGET_CMODEL != CMODEL_SMALL
+   && !TARGET_POWER10"
      "addis %0,%1@u(%2)")
     (define_insn "*largetoc_high_plus"
@@ -11303,7 +11305,8 @@
                (match_operand:DI 2 "gpc_reg_operand" "b")]
               UNSPEC_TOCREL)
           (match_operand:DI 3 "add_cint_operand" "n"))))]
-   "TARGET_ELF && TARGET_CMODEL != CMODEL_SMALL"
+   "TARGET_ELF && TARGET_CMODEL != CMODEL_SMALL
+   && !TARGET_POWER10"
      "addis %0,%2,%1+%3@toc@ha")
     (define_insn "*largetoc_high_plus_aix<mode>"
@@ -11314,28 +11317,75 @@
                (match_operand:P 2 "gpc_reg_operand" "b")]
               UNSPEC_TOCREL)
           (match_operand:P 3 "add_cint_operand" "n"))))]
-   "TARGET_XCOFF && TARGET_CMODEL != CMODEL_SMALL"
+   "TARGET_XCOFF && TARGET_CMODEL != CMODEL_SMALL
+   && !TARGET_POWER10"
      "addis %0,%1+%3@u(%2)")
     (define_insn "*largetoc_low"
     [(set (match_operand:DI 0 "gpc_reg_operand" "=r")
           (lo_sum:DI (match_operand:DI 1 "gpc_reg_operand" "b")
                  (match_operand:DI 2 "" "")))]
-   "TARGET_ELF && TARGET_CMODEL != CMODEL_SMALL"
+   "TARGET_ELF && TARGET_CMODEL != CMODEL_SMALL
+   && !TARGET_POWER10"
      "addi %0,%1,%2@l")
     (define_insn "*largetoc_low_aix<mode>"
     [(set (match_operand:P 0 "gpc_reg_operand" "=r")
           (lo_sum:P (match_operand:P 1 "gpc_reg_operand" "b")
                  (match_operand:P 2 "" "")))]
-   "TARGET_XCOFF && TARGET_CMODEL != CMODEL_SMALL"
+   "TARGET_XCOFF && TARGET_CMODEL != CMODEL_SMALL
+   && !TARGET_POWER10"
      "la %0,%2@l(%1)")
   +(define_insn "*largetocp10_high_low_aix<mode>"
+  [(set (match_operand:P 0 "gpc_reg_operand" "=b")
+    (unspec [(match_operand:P 1 "" "")
+         (match_operand:P 2 "gpc_reg_operand" "b")]
+        UNSPEC_TOCREL))]
+   "TARGET_XCOFF
+    && TARGET_POWER10
+    && TARGET_CMODEL != CMODEL_SMALL"
+   "addis %0,%1@u(%2)\;la %0,%1@l(%0)")
+
+(define_insn "*largetocp10_high_low_plus_aix<mode>"
+  [(set (match_operand:P 0 "gpc_reg_operand" "=b")
+    (plus:P
+      (unspec [(match_operand:P 1 "" "")
+           (match_operand:P 2 "gpc_reg_operand" "b")]
+          UNSPEC_TOCREL)
+      (match_operand:P 3 "add_cint_operand" "n")))]
+   "TARGET_XCOFF
+    && TARGET_POWER10
+    && TARGET_CMODEL != CMODEL_SMALL"
+   "addis %0,%1+%3@u(%2)\;la %0,%1+%3@l(%0)")
+
+(define_insn "*largetocp10_high_low"
+  [(set (match_operand:DI 0 "gpc_reg_operand" "=b")
+    (unspec [(match_operand:DI 1 "" "")
+         (match_operand:DI 2 "gpc_reg_operand" "b")]
+        UNSPEC_TOCREL))]
+   "TARGET_ELF
+    && TARGET_POWER10
+    && TARGET_CMODEL != CMODEL_SMALL"
+   "addis %0,%2,%1@toc@ha\;addi %0,%0,%1@toc@l")
+
+(define_insn "*largetocp10_high_low_plus"
+  [(set (match_operand:DI 0 "gpc_reg_operand" "=b")
+    (plus:DI
+      (unspec [(match_operand:DI 1 "" "")
+           (match_operand:DI 2 "gpc_reg_operand" "b")]
+          UNSPEC_TOCREL)
+      (match_operand:DI 3 "add_cint_operand" "n")))]
+   "TARGET_ELF
+    && TARGET_POWER10
+    && TARGET_CMODEL != CMODEL_SMALL"
+   "addis %0,%2,%1+%3@toc@ha\;addi %0,%0,%1+%3@toc@l")
+
   (define_insn_and_split "*tocref<mode>"
     [(set (match_operand:P 0 "gpc_reg_operand" "=b")
       (match_operand:P 1 "small_toc_ref" "R"))]
      "TARGET_TOC
-    && legitimate_constant_pool_address_p (operands[1], QImode, false)"
+    && legitimate_constant_pool_address_p (operands[1], QImode, false) && 
!TARGET_POWER10"
      "la %0,%a1"
      "&& TARGET_CMODEL != CMODEL_SMALL && reload_completed"
     [(set (match_dup 0) (high:P (match_dup 1)))
diff --git a/gcc/testsuite/gcc.target/powerpc/pr108018-1.c 
b/gcc/testsuite/gcc.target/powerpc/pr108018-1.c
new file mode 100644
index 000000000..5d88ca5cb
--- /dev/null
+++ b/gcc/testsuite/gcc.target/powerpc/pr108018-1.c
@@ -0,0 +1,14 @@
+/* { dg-do compile } */
+/* { dg-skip-if "" { powerpc*-*-aix* } } */
+/* { dg-options "-O2 -mdejagnu-cpu=power10 -mno-pcrel" } */
+
+/* Verify that the test case from PR108018 won't fail.  */
+
+static int foo, bar;
+
+unsigned long test(void)
+{
+        return (unsigned long)&foo + (unsigned long)&bar;
+}
+
+/* { dg-final { scan-assembler-times {addis [^\n]*\n\taddi } 3 } } */

Reply via email to