Re: [PATCHv2] libiberty: Preserve `errno` across calls to `libiberty_vprintf_buffer_size()`

[Jonathan Yong]

On 2/9/26 2:32 PM, Richard Biener wrote:

On Mon, Feb 9, 2026 at 2:56 PM LIU Hao <lh_mo...@126.com> wrote:

The MSVCRT `strtoul()` function resets `errno` to zero upon success. On such
a system, `libiberty_vprintf_buffer_size()` can clobber `errno` like this:

     MINGW64 ~
     $ ld nonexistent.file
     C:\MSYS64\mingw64\bin\ld.exe: cannot find nonexistent.file: No error

LGTM, please leave others some time to comment.

Thanks,
Richard.

libiberty/ChangeLog:

         * vprintf-support.c (do_strtoul): New function.
         (libiberty_vprintf_buffer_size): Replace `strtoul` with `do_strtoul`.

Signed-off-by: LIU Hao <lh_mo...@126.com>

Pushed to master branch, thanks.