[CC += Branden]

Hi David,

On Sat, Oct 11, 2025 at 07:09:34PM -0400, David Malcolm wrote:
> On Sun, 2025-09-28 at 10:09 +0200, Alejandro Colomar wrote:
> > Signed-off-by: Alejandro Colomar <[email protected]>
> > ---
> >  gcc/c-family/c-warn.cc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/gcc/c-family/c-warn.cc b/gcc/c-family/c-warn.cc
> > index a771444184f..e5e3ef70710 100644
> > --- a/gcc/c-family/c-warn.cc
> > +++ b/gcc/c-family/c-warn.cc
> > @@ -3505,7 +3505,7 @@ warn_parms_array_mismatch (location_t origloc,
> > tree fndecl, tree newparms)
> >  
> >        if (!newa)
> >     {
> > -     /* Continue of both parameters are pointers with no size
> > +     /* Continue if both parameters are pointers with no size
> >          associated with it.  */
> >       if (!cura)
> >         continue;
> 
> Hi Alejandro.
> 
> Thanks for the patches.  I think this kind of spelling fix is covered
> by the "obvious" rule on https://gcc.gnu.org/gitwrite.html#all though
> you'll need a ChangeLog for the server-side hooks to accept it the
> push.

Thanks!  Though I don't have write access (I don't have an account).

I'll add a changelog and resend.

> That said, perhaps the wording makes more sense if it's
>   "associated with them"
> rather than
>   "associated with it"
> ?  (I'm not sure)

I'm not sure either.  I've CCed Branden, who will probably know.

> Hope this is constructive
> Dave

Yup.  Thanks!


Have a lovely night!
Alex

-- 
<https://www.alejandro-colomar.es>
Use port 80 (that is, <...:80/>).

Attachment: signature.asc
Description: PGP signature

Reply via email to