The git blame shows it's replaced a 'find -delete' which already had an \; (also causing it to fail) so yeah, made me triple-check if this was intentional.
On Wed, Oct 15, 2025 at 12:33 PM Jeff Law <[email protected]> wrote: > > > > On 10/14/25 1:28 PM, Basil Milanich wrote: > > The extra \; parameter in the find command causes it to fail immediately and > > not clean any config.cache: > > > > $ find . -name config.cache -exec rm -f {} \; \; > > find: paths must precede expression: `;' > > > > This is benign in most cases but the binutils is also using this > > Makefile.tpl and > > as the result its 'make distclean' can leave config.cache files around, > > which > > fails subsequent attempts to configure and build it. > > > > I have modified the Makefile.tpl and regenerated Makefile.in from it. For > > testing > > I ran a config/make/make distclean loop. > Thanks. I checked the history here just in case there was something > subtle I was missing. But in that discussion there was only a single > ";" in the proposed line. Somehow we ended up with 2. > > I added a suitable ChangeLog entry and pushed this to the trunk. > Presumably at some point binutils will resync and pick this up. > > Thanks, > Jeff
