On 08/27/2012 02:44 AM, Ulrich Drepper wrote:
On Sun, Aug 26, 2012 at 1:36 PM, Jonathan Wakely <jwakely....@gmail.com> wrote:
But I've just seen Paolo's suggestion for a __generate_impl that both
use, and I prefer that idea.
How about the following. I introduced a __generate_impl() member
function. This required in a few cases an additional wrapper function
but nothing too bad. The template parameter order is changed, too.
Ah good. As far as I'm concerned this version is essentially ready to go
in. Are you set to commit to svn? (the advance patch is also pending, I
guess). It's been a while since your last commit to the C++ library, eh!
One last observation from me: I think we are being a little inconsistent
in terms of inlining. I see some __generate_impl with a non-trivial body
inline whereas other, with a tad smaller body, in random.tcc. Lately in
the C++ library we are quite picky in terms of avoiding code bloat and
even if this is computational code which likely may benefit from a tad
more inlining than usual, I would recommend that at first we standardize
on less inlining. We can always selectively move back at a later time
individual functions.
Paolo.
