Hi! On Fri, Oct 03, 2025 at 10:46:34AM +0100, Tamar Christina wrote: > This patch is a mechanical rewrite of the widen_[us]sum optabs from a direct > to > a conversion optab.
There is no optab (or table of any other kind) in this patch. Instead, it changes some pattern names, from well-known sort-of-standard names to not-so-standard names. Could you please make these new names standard (i.e. DOCUMENTED) first? And then refer to that documentation in this patch :-) > The result of which requires the output mode to be added to > the existing patterns. That sounds good :-) > * config/rs6000/altivec.md (widen_usum<mode>3): Renamed ... Please never use passive tense in changelogs. It should read like "do this, and do that", not like "something or other might be done (behind the scenes)". > (widen_usumv4si<mode>3): ... into this. Those new names are incorrect in any case, it should be widen_usumv4si<mode>2! There are only *two* <mode> thing operands in the pattern, after all. That is what the number means: something like "addsi3" is sort of shorthand for "addsisisi" (and addsi2di means addsisidi). So, (with the faulty names) this patch results in some better generated code? You might want to show that in the patch message, to motivate this change a bit :-) Thanks, Segher
