On Sun, 10 Aug 2025, Prathamesh Kulkarni wrote:
> Hi Matthew,
> Thanks for the suggestions! In the attached patch, I have modified
> libatomic/configure.ac to use
> __libatomic_save_CFLAGS__ instead of save_CFLAGS, so it isn't (accidentally)
> modified by ACX_PROG_CC_WARNING_OPTS.
>
> The patch also fixes couple of other issues you pointed out to me privately:
> (1) In Makefile.def, the patch adds following entry:
> +lang_env_dependencies = { module=libatomic; no_atomic=true; };
> To avoid the following circular dependency:
> make[2]: Circular configure-stage1-target-libatomic <-
> maybe-all-stage1-target-libatomic dependency dropped.
>
> (2) Moves the FIXME comment to top-level to avoid the following error in
> libatomic/Makefile.am:
> Makefile.am:176: error: '#' comment at start of rule is unportable.
>
> Patch is bootstrapped + tested on x86_64-linux-gnu, and aarch64-linux-gnu so
> far.
> Joseph, does this patch look OK to you ?
This patch is OK.
--
Joseph S. Myers
[email protected]
