On Wed, 2 Jul 2025, Robin Dapp wrote:
> > The else (get_group_load_store_type) can end up returning
> > VMAT_GATHER_SCATTER and thus require the above checking as well.
>
> Isn't this already covered by
>
> if (*memory_access_type == VMAT_ELEMENTWISE
> || (*memory_access_type == VMAT_GATHER_SCATTER
> && GATHER_SCATTER_LEGACY_P (*gs_info))
> || *memory_access_type == VMAT_STRIDED_SLP
> || *memory_access_type == VMAT_INVARIANT)
> {
> *alignment_support_scheme = dr_unaligned_supported;
> *misalignment = DR_MISALIGNMENT_UNKNOWN;
> }
> else
> {
> *misalignment = dr_misalignment (first_dr_info, vectype, *poffset);
> *alignment_support_scheme
> = vect_supportable_dr_alignment (vinfo, first_dr_info, vectype,
> *misalignment);
> }
>
> (now that non-legacy gather/scatter is not exempt from the alignment check any
> more)?
I'm not sure? I'd prefer some refactoring to make this more obvious
(and the split between the two functions doesn't help ...).
If you're sure it's all covered then ignore this comment, I can do
the refactoring as followup. It just wasn't obvious to me.
Richard.
