Martin Jambor <mjam...@suse.cz> writes: > Hi, > > When GCC is built with clang, it emits warnings that several member > functions of various ranger classes override a virtual function of an > ancestor but are not marked with the override keyword. After > inspecting the cases, I found that all these classes had other member > functions marked as final override, so I added the final keyword > everywhere too. > > In some cases other such overrides were not explicitly marked as > virtual, which made formatting easier. For that reason and also for > consistency, in such cases I removed the virtual keyword from the > functions I marked as final override too. > > Bootstrapped and tested on x86_64-linx. OK for master? > > Alternatively, as with all of these clang warning issues, I'm > perfectly happy to add an entry to contrib/filter-clang-warnings.py to > ignore the warnings instead.
I personally like the override keyword. It makes the intent clear. I think slapping virtual on everything was an artifact of a earlier era. OK by me. Thanks. Aldy
