[COMMITTED] Re: [PATCH] PR tree-optimization/119039 - Simplify switches utilizing subranges.

[Andrew MacLeod]

On 6/18/25 14:17, Andrew Pinski wrote:

On Wed, Jun 18, 2025, 11:11 AM Andrew MacLeod <amacl...@redhat.com> wrote:


    On 6/18/25 14:00, Andrew Pinski wrote:
    >
    >
    > +/* { dg-final { scan-tree-dump-not "foo" "evrp" } } */
    >
    > May I suggest this be changed to "foo " (adding a space). To avoid
    > maybe matching on a directory name that contains foo.
    >
    > I only noticed this today after you pushed thr change sorry.
    >
    > Thanks,
    > Andrew

    Is that really a thing? :-)

    I have no problem doing it, but I would guess its not an issue...
    a grep
    in just testsuite/gcc.dg shows

Yes there a bunch which has this problem. Tree scan might be less likely to have the issue compared to the assembly scans. I know I have had an accident failures due to directory names in the past so tightening up the scans I suspect is always a good thing.

Thanks,
Andrew

NP.  committed.



From 726bb4f7e16583d96c16f1a35c6f85835ae2d6de Mon Sep 17 00:00:00 2001
From: Andrew MacLeod <amacl...@redhat.com>
Date: Wed, 18 Jun 2025 14:28:20 -0400
Subject: [PATCH] Add space after foo in testcase

	gcc/testsuite/
	* gcc.dg/pr119039-1.c: Add space in search criteria.
---
 gcc/testsuite/gcc.dg/pr119039-1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.dg/pr119039-1.c b/gcc/testsuite/gcc.dg/pr119039-1.c
index 5ca65638853..f91d5eb7139 100644
--- a/gcc/testsuite/gcc.dg/pr119039-1.c
+++ b/gcc/testsuite/gcc.dg/pr119039-1.c
@@ -29,4 +29,4 @@ test (int i)
       break;
   }
 }
-/* { dg-final { scan-tree-dump-not "foo" "evrp" } } */
+/* { dg-final { scan-tree-dump-not "foo " "evrp" } } */
-- 
2.45.0