On Wed, Jun 18, 2025, 11:11 AM Andrew MacLeod <amacl...@redhat.com> wrote:
> > On 6/18/25 14:00, Andrew Pinski wrote: > > > > > > +/* { dg-final { scan-tree-dump-not "foo" "evrp" } } */ > > > > May I suggest this be changed to "foo " (adding a space). To avoid > > maybe matching on a directory name that contains foo. > > > > I only noticed this today after you pushed thr change sorry. > > > > Thanks, > > Andrew > > Is that really a thing? :-) > > I have no problem doing it, but I would guess its not an issue... a grep > in just testsuite/gcc.dg shows > Yes there a bunch which has this problem. Tree scan might be less likely to have the issue compared to the assembly scans. I know I have had an accident failures due to directory names in the past so tightening up the scans I suspect is always a good thing. Thanks, Andrew > > attr-noreturn.c:/* { dg-final { scan-tree-dump-not "foo" "optimized" } } */ > attr-returns-nonnull.c:/* { dg-final { scan-tree-dump-not "foo" > "optimized" } } */ > builtin-unreachable-2.c:/* { dg-final { scan-tree-dump-not "foo" > "optimized" } } */ > pr102648.c:/* { dg-final { scan-tree-dump-not "foo" "optimized" } } */ > pr102650.c:/* { dg-final { scan-tree-dump-not "foo" "vrp1" } } */ > pr102872.c:/* { dg-final { scan-tree-dump-not "foo" "evrp" } } */ > pr104526.c:/* { dg-final { scan-tree-dump-not "foo" "evrp" } } */ > pr104530.c:/* { dg-final { scan-tree-dump-not "foo" "evrp" } } */ > pr107822.c:/* { dg-final { scan-tree-dump-not "foo" "evrp" } } */ > pr108356.c:/* { dg-final { scan-tree-dump-not "foo" "optimized" } } */ > pr108359.c:/* { dg-final { scan-tree-dump-not "foo" "optimized" } } */ > pr109546.c:/* { dg-final { scan-tree-dump-not "foo" "optimized" } } */ > pr110080.c:/* { dg-final { scan-tree-dump-not "foo" "optimized" } } */ > pr110875.c:/* { dg-final { scan-tree-dump-not "foo" "vrp2" } } */ > pr110918.c:/* { dg-final { scan-tree-dump-not "foo" "optimized" } } */ > pr119039-1.c:/* { dg-final { scan-tree-dump-not "foo" "evrp" } } */ > pr20115-1.c:/* { dg-final { scan-tree-dump-times "foo" 1 "dom2" } } */ > pr97567-2.c:/* { dg-final { scan-tree-dump-not "foo" "evrp" } } */ > > > > > > > > > Bootstraps on x86_64-pc-linux-gnu with no regressions. OK for trunk? > > > > Andrew > > > > > >