Re: [PATCH v2] libstdc++: add range support to std::optional (P3168)

[Giuseppe D'Angelo]

Hello,

On 11/06/2025 14:18, Tomasz Kaminski wrote:

It should be sufficient to move only following to formatfwd.h to declare disabled specialization for optional. I do not think that we need to move to a partial specialization of format_kind for ranges

[snip]

And I would add a static_assert(!formattable<optional<int>>) to the tests.

You are not testing for the __cpp_lib_optional_range_support macro in the test file.

All done. New version pushed to Forge:

https://forge.sourceware.org/gcc/gcc-TEST/pulls/54/files

Thanks,
--
Giuseppe D'Angelo

smime.p7s
Description: S/MIME Cryptographic Signature