On Thu, Aug 9, 2012 at 8:45 AM, H.J. Lu <hjl.to...@gmail.com> wrote:
> On Fri, Apr 20, 2012 at 6:15 PM, Maxim Kuvyrkov <ma...@codesourcery.com> 
> wrote:
>> On 20/04/2012, at 1:34 PM, Fu, Chao-Ying wrote:
>>
>>> Hi Maxim, Richard,
>>>
>>>  I built cross-toolchains for 3 different targets as follows.
>>> 1. mips-linux-gnu
>>> 2. mips-linux-gnu --enable-targets=all
>>> 3. mips64-linux-gnu
>>>
>>>  These targets are affected by this MIPS Android patch.
>>>
>>>  Then, I checked the output from "gcc -dumpspecs" before and after applying 
>>> the patch.
>>> The specs have 6 places of differences for Android due to new defines in 
>>> linux-common.h.
>>> I am also building GCC natively, and will test GCC natively later.
>>> Any feedback?  Thanks!
>>>
>>> Regards,
>>> Chao-ying
>>>
>>> libgcc/ChangeLog
>>> 2012-04-19  Chao-ying Fu  <f...@mips.com>
>>>
>>>       * unwind-dw2-fde-dip.c: Define USE_PT_GNU_EH_FRAME for BIONIC.
>>
>> This piece is trivial, so, given that Richard approved the MIPS changes, you 
>> are clear to check in after amending the patch per Richard's comments.  
>> Please check in the patch to unwind-dw2-fde-dip.c separately, as it is a 
>> change on its own.
>>
>> Thank you,
>>
>
> This breaks Android/x86 build:
>
> #if defined(USE_PT_GNU_EH_FRAME)
>
> #include <link.h>
>
> but Bionic/x86 doesn't have link.h
>
> --
> H.J.

I opened:

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54209


-- 
H.J.

Reply via email to