Jeff Law <jeffreya...@gmail.com> writes: > On 5/16/25 11:32 AM, Richard Sandiford wrote: >> gen_exp currently supports the 's' (string) operand type. It would >> certainly be possible to make the upcoming bytecode patch support >> that too. However, the rtx codes that have string operands should >> be very rarely used in hard-coded define_insn/expand/split/peephole2 >> rtx templates (as opposed to things like attribute expressions, >> where const_string is commonplace). And AFAICT, no current target >> does use them like that. >> >> This patch therefore reports an error for these rtx codes, >> rather than adding code that would be unused and untested. >> >> gcc/ >> * genemmit.cc (generator::gen_exp): Report an error for 's' operands. > OK. And we'll get a pretty good sense if a port is doing something > really weird in this space from my tester once this patch goes in.
Yeah. I'm hoping my config-list.mk testing would have caught that though, since it should show up as a build-time failure. Thanks for the reviews. Richard
