Hi all, hi Yuao, first, thanks for your patch - you are awesome! I believe it fixes the issue reported by Steven in problem report (PR) 113414, https://gcc.gnu.org/PR113413
Thus: * * * [Linking PR numbers] In order to correlate commits to issued (and get them automatically linked), the commit log should contain a reference. The syntax is <tab> + "PR " + space + <component> + "/" + number, i.e. here: (tab) PR fortran/113413. However, when using mklog.py, it takes already care of the syntax: * Use '-b' to specify the bug number or * If in the first few lines of a (test) file, a PRxxx or PR comp/xxx appears, mklog.py assumes that's a PR number. Unless you already use 'PR comp/123", this doesn't automatically add the component to the commit changelog. However, if you invoke mklog.py with '-p', it queries Bugzilla – and fills in the component. Additionally, '-p' includes the bug title(s) in the template; that's a good way to cross check the number as it is easily to mistype a longer number. [PR number in the commit/email subject] Consider to add the PR number to the mail – most common is to append [PR1234] at the end (i.e. without component). However, there are no firm rules about this. Sometimes, leaving it out completely make most sense (e.g. if several bugs are fixed) or if the subject line already very long; additionally, different persons have different styles - and use a different style. * * * (Pre-existing documentation issue, but should be fixed alongside:) Looking at the documentation and comparing ATAND to ATAN, https://gcc.gnu.org/onlinedocs/gfortran/ATAND.html and https://gcc.gnu.org/onlinedocs/gfortran/ATAN.html * Synopsis should also show the two-argument version * "ifY is present,X shall be REAL" does no make sense as ATAND (contrary to ATAN) does not permit complex values * Something like "If Y is present, the result is identical to ATAN2D(Y,X). Otherwise," is missing. * "range -90 \leq \Re \atand(x) \leq 90": the 'Re' IMHO doesn't make sense as the argument must always be real. * * * [I have still to look at the rest of the patch, but at a glance it looks fine.] Thanks again for your patch! Tobias
