Hi Karl, > On 7 May 2025, at 12:27, Karl Meakin <karl.mea...@arm.com> wrote: > > This patch series adds support for the CMPBR extension. It includes the > new `+cmpbr` option and rules to generate the new instructions when > lowering conditional branches.
Thanks for the series. You didn’t state it explicitly, but have you run a bootstrap and testsuite run with this series? It’s usually best to include testing information in the patches to help reviewers. Thanks, Kyrill > > Karl Meakin (8): > AArch64: place branch instruction rules together > AArch64: reformat branch instruction rules > AArch64: rename branch instruction rules > AArch64: add constants for branch displacements > AArch64: make `far_branch` attribute a boolean > AArch64: recognize `+cmpbr` option > AArch64: precommit test for CMPBR instructions > AArch64: rules for CMPBR instructions > > .../aarch64/aarch64-option-extensions.def | 2 + > gcc/config/aarch64/aarch64-simd.md | 2 +- > gcc/config/aarch64/aarch64-sme.md | 3 +- > gcc/config/aarch64/aarch64.cc | 2 +- > gcc/config/aarch64/aarch64.h | 3 + > gcc/config/aarch64/aarch64.md | 557 +++++--- > gcc/config/aarch64/iterators.md | 5 + > gcc/config/aarch64/predicates.md | 17 + > gcc/doc/invoke.texi | 3 + > gcc/testsuite/gcc.target/aarch64/cmpbr.c | 1238 +++++++++++++++++ > 10 files changed, 1615 insertions(+), 217 deletions(-) > create mode 100644 gcc/testsuite/gcc.target/aarch64/cmpbr.c > > -- > 2.45.2 >
