> This looks wrong to me. Even tail calls can be terminated with exit, > perform longjmp, do other things for which stmt_can_terminate_bb_p > should return true. stmt_can_terminate_bb_p is used in many places, not > just in the predict instrumentation.
Okay so the check should be only used for setting up the edges. I will move it to the caller. > IMHO all we should ensure is that instrumentation isn't added after such > calls. I looked for an easy way to detect it in profile.cc, but didn't find one. -Andi