> -----Original Message----- > From: Jakub Jelinek <ja...@redhat.com> > Sent: Monday, March 17, 2025 03:07 > To: Robert Dubner <rdub...@symas.com> > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] cobol: Eighteen new testcases to cobol.dg/group1. > > On Sun, Mar 16, 2025 at 08:55:39PM -0500, Robert Dubner wrote: > > And if you liked that, you'll love this > > > > I had some with too much output for the regex to handle; I got > > out-of-memory errors on my 32-gigabyte x86_64. > > On some tests included here or another?
All of these tests run in 32GB. How much of it they use, I don't know. > This would be a major problem. > Generally, we want to allow even cross-testing from 32-bit architectrures, > so they'd better fit into 3GB of memory at most. At the present time, the executables cannot be compiled for 32-bit architectures, so for now I would think that is moot. > So if there is something that needs that much, we need to either find out > what is wrong in the dg-output regexps on a particular test or > add some different option (like a directive which would specify a text > file > to be compared to the output instead of a regex, or a text file with some > extra directives (like Andreas mentioned e.g. binutils uses). A directive that says, "Compare the executable's output to a file" would be glorious. I have trouble understanding how the project has existed through eight American presidential administrations and the dissolution of the Soviet Union without that capability. I haven't investigated what binutils does. > > > gcc/testsuite > > > > * cobol.dg/group1/check_88.cob: Revised regex to (\n|\r\n|\r). > > * cobol.dg/group1/comp5.cob: New testcase. > > * cobol.dg/group1/compute-1.cob: New testcase. > > * cobol.dg/group1/declarative_1.cob: New testcase. > > * cobol.dg/group1/display.cob: New testcase. > > * cobol.dg/group1/display2.cob: New testcase. > > * cobol.dg/group1/initialize_1.cob: New testcase. > > * cobol.dg/group1/moves.cob: New testcase. > > * cobol.dg/group1/multiple-compares.cob: New testcase. > > * cobol.dg/group1/multiply2.cob: New testcase. > > * cobol.dg/group1/numeds.cob: New testcase. > > * cobol.dg/group1/packed.cob: New testcase. > > * cobol.dg/group1/perform-nested-exit.cob: New testcase. > > * cobol.dg/group1/pointer1.cob: New testcase. > > * cobol.dg/group1/simple-arithmetic.cob: New testcase. > > * cobol.dg/group1/simple-classes.cob: New testcase. > > * cobol.dg/group1/simple-if.cob: New testcase. > > * cobol.dg/group1/simple-perform.cob: New testcase. > > * cobol.dg/group1/tripled.cob: New testcase. > > Still ChangeLog related notes, there should be no such aligning between > : and following uppercase letter. The format is > tab * space filename colon space description > or > tab * space filename space ( function ) colon space description > (and some others, e.g. <case XYZ> can be used to narrow it further. > So, all the New words above should be one space after .cob: > and Revised as well. > > > + MOVE C-5A TO PC DISPLAY PTR " Should be 0x0000000000000000". > > + MOVE C-5B TO PC DISPLAY PTR " Should be 0x0000000020202020". > > + MOVE C-5C TO PC DISPLAY PTR " Should be 0x0000000030303030". > > + MOVE C-5D TO PC DISPLAY PTR " Should be 0x0000000022222222". > > + MOVE C-5E TO PC DISPLAY PTR " Should be 0x00000000ffffffff". > > + stop run. > > + > > + > > If not really needed for the particular tests, I'd suggest to trim down > trailing whitespace, end last line with newline but don't add further > blank > newlines. This repeats in many tests. Understood. What you found there is source code, not output from an executable, but I understand. Bob D. > > Jakub
