Hello Jakub: Thank you very much for your feedback. See additional replies below.
On Thu, Mar 13, 2025 at 10:31:44PM +0100, Jakub Jelinek wrote: > On Thu, Mar 13, 2025 at 05:25:26PM -0400, Ayan Shafqat wrote: > > gcc/testsuite/ChangeLog: > > > > * gcc.target/aarch64/acle/acle_sqrt.c: New test. > > > > Signed-off-by: Ayan Shafqat <ayan.x.shaf...@gmail.com> > > Tests should be in the same patch as the code they are testing, > not committed separately. Yes, thanks for pointing this out. I agree that tests should be in the same commit as of introduction of the new feature. I have merged the two changes into one in the new version. Please see the newer version of this patch: https://gcc.gnu.org/pipermail/gcc-patches/2025-March/677754.html > > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/aarch64/acle/acle_sqrt.c > > @@ -0,0 +1,17 @@ > > +/* { dg-do compile } */ > > +/* { dg-options "-O2" } */ > > + > > +#include "arm_acle.h" > > + > > +double test_acle_sqrt (double x) > > The normal GNU formatting is > double > test_acle_sqrt (double x) > (i.e. function name at the start of line, so one can grep for it). > > > +{ > > + return __sqrt (x); > > +} > > + > > +float test_acle_sqrtf (float x) > > Ditto. > > Jakub > Thanks, I have addressed it in the v2 of this patch. Let me know if there are any other issues. Best, Ayan
