On Thu, Mar 13, 2025 at 05:25:26PM -0400, Ayan Shafqat wrote:
> This patch introduces acle_sqrt.c in the AArch64 testsuite, verifying
> that the new __sqrt and __sqrtf intrinsics emit the expected fsqrt
> instructions for double and float arguments.
> 
> Coverage for new intrinsics ensures that __sqrt and __sqrtf are
> correctly expanded to hardware instructions and do not fall back to
> library calls, regardless of optimization levels.
> 
> gcc/testsuite/ChangeLog:
> 
>       * gcc.target/aarch64/acle/acle_sqrt.c: New test.
> 
> Signed-off-by: Ayan Shafqat <ayan.x.shaf...@gmail.com>

Tests should be in the same patch as the code they are testing,
not committed separately.

> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/aarch64/acle/acle_sqrt.c
> @@ -0,0 +1,17 @@
> +/* { dg-do compile } */
> +/* { dg-options "-O2" } */
> +
> +#include "arm_acle.h"
> +
> +double test_acle_sqrt (double x)

The normal GNU formatting is
double
test_acle_sqrt (double x)
(i.e. function name at the start of line, so one can grep for it).

> +{
> +  return __sqrt (x);
> +}
> +
> +float test_acle_sqrtf (float x)

Ditto.

        Jakub

Reply via email to