Hi Jakub: Thank you very much for the review feedback. I have addressed the feedback in v2 of the patch [1]. See additional replies below.
[1] https://gcc.gnu.org/pipermail/gcc-patches/2025-March/677754.html On Thu, Mar 13, 2025 at 10:28:52PM +0100, Jakub Jelinek wrote: > On Thu, Mar 13, 2025 at 05:23:00PM -0400, Ayan Shafqat wrote: > > This patch introduces two new inline functions, __sqrt and __sqrtf, in > > +__sqrt(double __x) > Just formatting nits, there should be space in between the function name > and ( and only one space between double and __x. Thanks for catching this. > Also, it is unclear why it uses __extension__ (but admittedly it is used > elsewhere in the header. That is a question to the ARM maintainers. I have followed the convention in the rest of the file. If that needs changes, let me know. > > > +{ > > + return __builtin_aarch64_sqrtdf (__x); > > Just two space indentation rather than 4 spaces. Got it! Thanks for pointing this out. > > > +} > > + > > +__extension__ extern __inline float > > +__attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) > > +__sqrtf(float __x) > > See above > > > +{ > > + return __builtin_aarch64_sqrtsf (__x); > > Ditto > > Jakub > Thank you again for the review. Let me know if you spot anything else. Best regards, Ayan
