> As part of the Git commit message, please include a ChangeLog update (see
> <https://gcc.gnu.org/codingconventions.html#ChangeLogs> and 'git log').

I've written a new patch which is attached.

> Basically, 'contrib/gcc-changelog/git_check_commit.py --print-changelog'
> needs to accept your commit.

This time it passed the check!  Thank you, Thomas!

>> -       struct target_mem_desc *k_tgt = k->tgt;
>> -       bool is_tgt_unmapped = gomp_remove_var (devicep, k);
>> +       bool is_tgt_unmapped __attribute__((unused))
>> +         = gomp_remove_var (devicep, k);
>>          /* It would be bad if TGT got unmapped while we're still iterating
>>             over its LIST_COUNT, and also expect to use it in the following
>>             code.  */
>>          assert (!is_tgt_unmapped
>> -               || k_tgt != tgt);
>> +               || k->tgt != tgt);
>>        }
>
> Please check: if I remember correctly, it's no longer valid to dereference
> 'k->tgt' after 'gomp_remove_var (devicep, k);'?  (That's why we preserve the
> former as 'k_tgt'.)

My mistake.  I'm sorry.

Attachment: 0001-Add-__attribute__-unused-to-variables-used-only-in-a.patch
Description: 0001-Add-__attribute__-unused-to-variables-used-only-in-a.patch

Reply via email to