On Thu, Jan 30, 2025 at 8:49 PM Alexandre Oliva <ol...@adacore.com> wrote: > > > The test expects transformations that depend on -Ofast on x86*, but > that option is only passed when the avx_runtime is available. > > Split -Ofast out of the avx conditional, so that it is passed on the > same targets that expect the transformation.
It effectively would require -Ofast on all targets (it's vectorizing a FP reduction), so I'd say -Ofast should not depend on x86 only. > Regstrapped on x86_64-linux-gnu, also tested with gcc-14 targeting > x86_64-elf. Ok to install? > > > for gcc/testsuite/ChangeLog > > * gcc.dg/vect/vect-ifcvt-18.c: Split -Ofast out of > avx_runtime. > --- > gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c > b/gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c > index c1d3c27d81933..228011ae07bce 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c > @@ -1,6 +1,7 @@ > /* { dg-require-effective-target vect_condition } */ > /* { dg-require-effective-target vect_float } */ > -/* { dg-additional-options "-Ofast -mavx" { target avx_runtime } } */ > +/* { dg-additional-options "-Ofast" { target i?86-*-* x86_64-*-* } } */ > +/* { dg-additional-options "-mavx" { target avx_runtime } } */ > > > int A0[4] = {36,39,42,45}; > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > More tolerance and less prejudice are key for inclusion and diversity > Excluding neuro-others for not behaving ""normal"" is *not* inclusive