On Thu, 23 Jan 2025, Maciej W. Rozycki wrote:

> > This patch adds a MIPS64 implementation of `fiber_switchContext',
> > replacing the generic implementation.  The `core.thread.fiber' module
> > already defines version=AsmExternal on mips64el-linux-gnuabi64 targets.
> 
>  Don't you need similar code for n32 MIPS64 (_ABIN32)?
> 
>  That would be s/daddiu/addiu/ for the stack updates and otherwise the 
> same as this piece.

 Self-update: also s/sd/sw/ here:

> +    // swap stack pointer
> +    sd   $sp, 0($a0)

because (void *) is 32-bit (ILP32), but frame slots use the full register 
width.

  Maciej

Reply via email to