On 16/07/2012, at 6:56 PM, Maxim Kuvyrkov wrote:

> On 16/07/2012, at 6:37 PM, Chung-Lin Tang wrote:
> 
>> On 2012/7/16 12:28 AM, Richard Sandiford wrote:
>>> Chung-Lin Tang <clt...@codesourcery.com> writes:
>>>> This patch adds scheduling support for the NetLogic XLP, including a new
>>>> pipeline description, and associated changes.
>>>> 
>>>> Asides from the new xlp.md description file, there are also some sync
>>>> primitive attribute modifications, for better scheduling of sync loops
>>>> (Maxim should be able to better explain this).
>>> 
>>> Rather than add a "type" attribute to each sync loop, please just add:
>>> 
>>>       (not (eq_attr "sync_mem" "none"))
>>>       (symbol_ref "syncloop")
>>> 
>>> to the default value of the "type" attribute.  You'll probably need
>>> to swap the order of the sync* attributes with the "type" attribute
>>> in order for this to compile.
>>> 
>>> The patch is effectively changing the type of the sync loops from
>>> "unknown" to "syncloop".  That's certainly OK, but you'll need to
>>> add "syncloop" to the "unknown" reservations of all other schedulers
>>> (except for generic.md, where what you've done instead is fine).
>>> It might be easier if you split out the addition of syncloop
>>> as a separate patch.
>> 
>> I'll leave it to Maxim to respond to the sync parts.
> 
> Richard, that's indeed simpler, thanks.

Attached is a stand-alone patch that adds handling of "syncloop" and "atomic" 
type attributes.

Tested by building cross-toolchain mips64-linux-gnu including GLIBC.  OK to 
apply?

--
Maxim Kuvyrkov
CodeSourcery / Mentor Graphics

Attachment: 0001-Support-scheduling-of-sync-loops-and-atomic-instruct.patch
Description: Binary data



Reply via email to