On 21/11/2024 17:23, Torbjörn SVENSSON wrote: > I'm not sure how to verify that adding the parameter won't destroy the test. > I've tried to repoduce the ICE on old Arm builds of arm-none-eabi, but none of > them ICE. I suppose it should be safe to add the parameter as the PR talks > about the literal pools. > > Ok for trunk and releases/gcc-14? > > -- > > Without this change, build fails with: > > .../thumb2-slow-flash-data-3.c: In function 'fn3': > .../thumb2-slow-flash-data-3.c:23:3: error: too many arguments to function > 'fn1' > .../thumb2-slow-flash-data-3.c:10:6: note: declared here > > gcc/testsuite/ChangeLog: > > * gcc.target/arm/thumb2-slow-flash-data-3.c: Added argument to > fn1 to avoid compile error. > > Signed-off-by: Torbjörn SVENSSON <torbjorn.svens...@foss.st.com>
This is OK. The alternative would be to force an older version of the C standard via dg-options, but I don't think that's necessary here. R.
