On 11/27/24 4:12 AM, Nathaniel Shead wrote:
On Thu, Nov 21, 2024 at 07:51:55PM +0100, Jason Merrill wrote:
On 11/9/24 9:22 AM, Nathaniel Shead wrote:
Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? Given
that this doesn't actually fix the modules PR c++/116568 anymore I've
pulled my workaround for that out as a separate patch (3/3).
In general, mangling changes should depend on -fabi-version, and tests
should verify both the old and new mangling. Likewise for patch 2/3.
OK, thanks. Does this include C++20-only ABI-changes, such as for
unevaluated lambdas or lambdas in template arguments? (Since my
understanding is that we currently consider C++20 to be unstable.)
Good point, it isn't needed for changes that only affect experimental
modes. So patch 2 doesn't need it.
If we're going to need to do this anyway I think I might wait until I
can create actual correct manglings in all cases, not just this slightly
better one (see [1] for where I got stuck last time I had a chance to
look at this).
Also FYI, due to some recent changes in life circumstances I do not
currently have much time to make contributions, so I probably won't be
able to work on this until next year.
Ah, sorry to hear that, but thanks for letting me know.
Jason
