Monday, September 2, 2024 3:15 PM Kyrylo Tkachov <ktkac...@nvidia.com> wrote:
>> libstdc++-v3/ChangeLog: >> >> * src/c++17/fast_float/fast_float.h (defined): Adjust a condition >> for AArch64. > > libstdc++ is reviewed on its own list (CC’ed here) so I’d suggest splitting > the libstdc++-v3 hunk into its own patch and submitting it separately there > for review. Monday, September 2, 2024 3:45 PM Jonathan Wakely <jwakely....@gmail.com> wrote: > fast_float is an external project there we import. Has this fix been sent > upstream? > It looks like this changelog was created by the mklog script, but it needs > fixing. This is not changing "defined". It looks like it's changing > "full_multiplication" so that's what should be named in the changelog. Thank you, Kyrylo and Jonathan, for clarifying the process for upstreaming changes to fast_float. The change has been upstreamed to the fast_float and libstdc++ patch has been prepared. https://gcc.gnu.org/pipermail/libstdc++/2024-September/059472.html