Hi!
On Thu, Aug 22, 2024 at 08:48:19PM -0500, Peter Bergner wrote:
> I was a little surprised we didn't have that macro already. Ok, consider
> it changed with your suggestion.
>
> I agree, there probably is code in the backend that currently handles TImode
> that should probably be changed to handle both by using your new macro.
That is what mode classes are for, or just the mode size here :-)
> >> +/* { dg-do run } */
> >> +/* { dg-skip-if "" { powerpc*-*-darwin* } } */
> >
> > Nit: This dg-skip-if line looks not necessary as p8vector_hw excludes
> > *-*-darwin*.
Every single "skip-if darwin" is incorrect if it isn't added by Iain.
Skipping a test on some target is fine, if it would fail on that target
(but do put a comment in!), but skipping because you are scared it will
fail on some target, or you don't care about that target, or just
cargo-cult, is wrong, and encourages more wrongness.
Segher
