Hi!
On Thu, Aug 22, 2024 at 05:39:36PM +0800, Kewen.Lin wrote:
> > - if (ALTIVEC_OR_VSX_VECTOR_MODE (mode) || mode == TImode)
> > + if (ALTIVEC_OR_VSX_VECTOR_MODE (mode) || mode == TImode
> > + || mode == PTImode)
>
> Maybe we can introduce a macro to this file like
>
> #define TI_OR_PTI_MODE(mode) ((mode) == TImode || (mode) == PTImode)
INTEGRAL_MODE_P (mode) && MODE_UNIT_SIZE (mode) == 16 or such?
Or you might just want the check for 16, that covers all applicable
modes and nothing else, right?
The correct indentation is
if (ALTIVEC_OR_VSX_VECTOR_MODE (mode)
|| mode == TImode
|| mode == PTImode)
btw, or you can put the TImode and PTImode on one line if you really
have to, but don't put unalike things on the same line.
I don't like macros that you use just one or two times. It is much
clearer if you write it out whereever you use it.
> OK for trunk and all active release branches with/without these nits tweaked,
> but please give others two days or so to comment, thanks!
Okay for trunk right now, and backports after the customary wait. Also
okay with just the MODE_UNIT_SIZE (mode) == 16 thing, after you tested
that of course :-)
Thanks!
Segher
