Hello, Bernd,

Thanks for the fixes and improvements, your patch looks good to me.  I
stand behind its approval by someone with authority to do so.

I believe location views are somewhat problematic on RISC-V, because of
the object code relaxations.  Its usefulness is also limited without
support from debug consumers.

It's unfortunate, in hindsight, that inline entry points ended up tied
to location views.  I can't recall any strong reason for that.  I
suppose lifting that requirement, so as to enable inline points even
without location views, would be desirable.  Would you be interested in
pursuing that?

On Aug 21, 2024, Bernd Edlinger <bernd.edlin...@hotmail.de> wrote:

> gcc/ChangeLog:

>         * dwarf2out.cc (dwarf2out_maybe_output_loclist_view_pair,
>         output_loc_list): Correct handling of -gno-as-loc-support,
>         use ZERO_VIEW_P to output view number as zero value.
>         * toplev.cc (process_options): Do not automatically disable
>         -gvariable-location-views when -gno-as-loc-support or
>         -gno-as-locview-support is used.

> gcc/testsuite/ChangeLog:

>         * gcc.dg/debug/dwarf2/inline2.c: Add checks for inline entry_pc.
>         * gcc.dg/debug/dwarf2/inline6.c: Add -gno-as-loc-support and check
>         the resulting location views.

-- 
Alexandre Oliva, happy hacker            https://FSFLA.org/blogs/lxo/
   Free Software Activist                   GNU Toolchain Engineer
More tolerance and less prejudice are key for inclusion and diversity
Excluding neuro-others for not behaving ""normal"" is *not* inclusive

Reply via email to