On Wed, 19 Jun 2024, YunQiang Su via Gcc-cvs wrote:

> diff --git a/configure b/configure
> index 51576a41f303..6e95b27d9df4 100755
> --- a/configure
> +++ b/configure
> @@ -8994,15 +8994,15 @@ if test "$ac_res" != no; then :
>  fi
>  
>  
> -if test $ac_cv_search_dlopen = -ldl; then
> +if test "$ac_cv_search_dlopen" = -ldl; then
>      CRAB1_LIBS="$CRAB1_LIBS -ldl"
> -elif test $ac_cv_search_dlopen = no; then
> +elif test "$ac_cv_search_dlopen" = no; then
>      missing_rust_dynlibs="libdl"
>  fi
>  
> -if test $ac_cv_search_pthread_create = -lpthread; then
> +if test "$ac_cv_search_pthread_create" = -lpthread; then
>      CRAB1_LIBS="$CRAB1_LIBS -lpthread"
> -elif test $ac_cv_search_pthread_crate = no; then
> +elif test "$ac_cv_search_pthread_crate" = no; then
>      missing_rust_dynlibs="$missing_rust_dynlibs, libpthread"
>  fi
>  

 There's still an unfixed typo here, it should have been corrected in the 
same commit since the lines have been changed anyway.

> @@ -19746,7 +19746,7 @@ config.status
>  configured by $0, generated by GNU Autoconf 2.69,
>    with options \\"\$ac_cs_config\\"
>  
> -Copyright (C) 2012 Free Software Foundation, Inc.
> +Copyright (C)  Free Software Foundation, Inc.
>  This config.status script is free software; the Free Software Foundation
>  gives unlimited permission to copy, distribute and modify it."
>  

 There seems to be a tooling problem here.

> diff --git a/gcc/configure.ac b/gcc/configure.ac
> index b2243e9954aa..1501bf89c89d 100644
> --- a/gcc/configure.ac
> +++ b/gcc/configure.ac
> @@ -5317,7 +5317,7 @@ x:
>  
>      AC_MSG_CHECKING(assembler and linker for explicit JALR relocation)
>      gcc_cv_as_ld_jalr_reloc=no
> -    if test $gcc_cv_as_mips_explicit_relocs = yes; then
> +    if test "x$gcc_cv_as_mips_explicit_relocs" = "xyes"; then
>        if test $in_tree_ld = yes ; then
>          if test "$gcc_cv_gld_major_version" -eq 2 -a 
> "$gcc_cv_gld_minor_version" -ge 20 -o "$gcc_cv_gld_major_version" -gt 2 \
>             && test $in_tree_ld_is_elf = yes; then

 This should not have been bundled with the other change, because it is 
unrelated and more importantly clearly it has to be backported to the 
relevant release branches.

  Maciej

Reply via email to