> I'm not sure I'm following. Did we miss something that should have been > covered? Like only an overlap on the srcs but not the dest? > Are there testcases that fail? If so we should definitely have one.
> If something is broken then indeed we should revert it. Yes, we may need to support these in gcc-15. > ... why not just revert everything and xfail all the tests in a > follow up? Your patch is essentially a revert but doesn't look like > it. I'd rather we let a revert be a revert and adjust the tests > separately so it becomes clear. Sure, will revert b3b2799b872 and then file the patch for the xfail tests. Pan -----Original Message----- From: Robin Dapp <rdapp....@gmail.com> Sent: Friday, April 19, 2024 10:54 PM To: Li, Pan2 <pan2...@intel.com>; gcc-patches@gcc.gnu.org Cc: rdapp....@gmail.com; juzhe.zh...@rivai.ai; kito.ch...@gmail.com Subject: Re: [PATCH v1] RISC-V: Revert RVV wv instructions overlap and xfail tests Hi Pan, > The RVV register overlap requires both the dest, and src operands. > Thus the rigister filter in constraint cannot cover the fully sematics > of the vector register overlap. I'm not sure I'm following. Did we miss something that should have been covered? Like only an overlap on the srcs but not the dest? Are there testcases that fail? If so we should definitely have one. If something is broken then indeed we should revert it. But... > Thus, revert these overlap patches list and xfail the related test > cases. This patch would like to revert *b3b2799b872*, and the full > picture of related series are listed as below. ... why not just revert everything and xfail all the tests in a follow up? Your patch is essentially a revert but doesn't look like it. I'd rather we let a revert be a revert and adjust the tests separately so it becomes clear. Regards Robin
