On 1/19/24 18:18, 钟居哲 wrote:
OK. I saw the other arguments there:
tree fntype ATTRIBUTE_UNUSED,
rtx libname ATTRIBUTE_UNUSED,
So I leverage these and add ATTRIBUTE_UNUSED to 'fndecl'
Maybe it's better remove all arguments for riscv_init_cumulative_args
which are unused as you suggested.
Yea. The biggest problem with ATTRIBUTE_UNUSED is that it's a "may be
unused" and thus if the code changes it's sometimes left on an parameter
incorrectly. C++ allows us to specify a "is definitely unused" concept
by dropping the parameter's name, but leaving its type.
I just pushed the obvious patch to fixup that function signature. It
would be a nice easy task for someone to go through all of riscv*.cc and
clean those up after gcc-14 branches.
jeff
