On Wed, Nov 22, 2023 at 4:18 PM Jeff Law <jeffreya...@gmail.com> wrote: > > > > On 11/21/23 16:27, Palmer Dabbelt wrote: > > The vectorizer picks up these loops and disables unrolling on targets > > with variable vector factors. That result in better code here, but it > > trips up the unrolling tests. So just disable vectorization for these. > > > > gcc/testsuite/ChangeLog: > > > > PR target/112531 > > * gcc.dg/unroll-8.c: Disable vectorization on arm64 and riscv. > So probably the right check is to test for vector and > !vect_variable_length rather than doing something target specific for > aarch64/riscv
Yes I think that would definitely be better. > > Jeff