On Tue, 10 Oct 2023, 钟居哲 wrote:

> I know you want vect_int to block the test for rv64gc. 
> But unfortunately it failed.

 Why?

> And I have changed everything to run vect testsuite with "riscv_v".
> [PATCH] RISC-V: Enable more tests of "vect" for RVV (gnu.org)
> 
> So to be consistent, plz add "riscv_v".

 I'll experiment with things here.

 NB it makes sense to sort targets alphabetically in these feature tests: 
not only it makes it easier to find whether your target of interest is 
present in the ever increasing list, but there's less clobber as new 
targets are added as well, because most time you don't need to fiddle with 
the test that becomes the second last, which in turn means `git blame' 
won't show you the noise and save you one step when chasing later on the 
original commit that has added it.  This is why I added my new check in 
the middle, roughly alphabetically (as the order is a bit messy at 
present), and you can see how cleaner the resulting change is.

  Maciej

Reply via email to