Committed, thanks Richard. Pan
-----Original Message----- From: Richard Biener <rguent...@suse.de> Sent: Wednesday, September 27, 2023 3:18 PM To: Juzhe-Zhong <juzhe.zh...@rivai.ai> Cc: gcc-patches@gcc.gnu.org; richard.sandif...@arm.com; jeffreya...@gmail.com Subject: Re: [PATCH] ifcvt: Fix comments On Wed, 27 Sep 2023, Juzhe-Zhong wrote: > Fix comments since original comment is confusing. OK > gcc/ChangeLog: > > * tree-if-conv.cc (is_cond_scalar_reduction): Fix comments. > > --- > gcc/tree-if-conv.cc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gcc/tree-if-conv.cc b/gcc/tree-if-conv.cc > index 799f071965e..a8c915913ae 100644 > --- a/gcc/tree-if-conv.cc > +++ b/gcc/tree-if-conv.cc > @@ -1747,11 +1747,11 @@ is_cond_scalar_reduction (gimple *phi, gimple > **reduc, tree arg_0, tree arg_1, > > and convert to > > - reduc_2 = PHI <0, reduc_3> > - tmp1 = (unsigned type)reduce_1; > + reduc_2 = PHI <0, reduc_1> > + tmp1 = (unsigned type)reduc_1; > ifcvt = cond_expr ? rhs2 : 0 > tmp2 = tmp1 +/- ifcvt; > - reduce_1 = (signed type)tmp2; */ > + reduc_1 = (signed type)tmp2; */ > > if (CONVERT_EXPR_CODE_P (reduction_op)) > { > -- Richard Biener <rguent...@suse.de> SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)