Committed, thanks Jeff and Robin. Pan
-----Original Message----- From: Jeff Law <jeffreya...@gmail.com> Sent: Tuesday, September 19, 2023 1:44 AM To: Robin Dapp <rdapp....@gmail.com>; Li, Pan2 <pan2...@intel.com>; gcc-patches@gcc.gnu.org Cc: juzhe.zh...@rivai.ai; Wang, Yanzhang <yanzhang.w...@intel.com>; kito.ch...@gmail.com Subject: Re: [PATCH v1] RISC-V: Bugfix for scalar move with merged operand On 9/18/23 04:00, Robin Dapp wrote: >> I must be missing something. Doesn't insn 10 broadcast the immediate >> 0x2 to both elements of r142?!? What am I missing? > It is indeed a bit misleading. The difference is in the mask which > is not displayed in the short form. So we actually use a vec_dup > for a single-element move, essentially a masked vec_dup where only > one element is masked in. Ah :-) > > The problem was that the original doesn't use a merging "vec_set" > but a "destructive" one where the other elements get ignored. > > The fix is OK IMHO. Agreed. jeff
