On Tue, Sep 12, 2023 at 5:00 PM Mark Wielaard <m...@klomp.org> wrote: > > Hi Maxim, > > Adding Jeff to CC who is the official gcc-patches mailinglist admin. > > On Tue, 2023-09-12 at 11:08 +0400, Maxim Kuvyrkov wrote: > > Normally, notifications from Linaro TCWG precommit CI are sent only to > > patch author and patch submitter. In this case the sender was rewritten > > to "Benjamin Priour via Gcc-patches <gcc-patches@gcc.gnu.org>", > > which was detected by Patchwork [1] as patch submitter. > > BTW. Really looking forward to your talk at Cauldron about this! > > > Is "From:" re-write on gcc-patches@ mailing list a side-effect of [2]? > > I see that some, but not all messages to gcc-patches@ have their > > "From:" re-written. > > > > Also, do you know if re-write of "From:" on gcc-patches@ is expected? > > Yes, it is expected for emails that come from domains with a dmarc > policy. That is because the current settings of the gcc-patches > mailinglist might slightly alter the message or headers in a way that > invalidates the DKIM signature. Without From rewriting those messages > would be bounced by recipients that check the dmarc policy/dkim > signature. > > As you noticed the glibc hackers have recently worked together with the > sourceware overseers to upgrade mailman and alter the postfix and the > libc-alpha mailinglist setting so it doesn't require From rewriting > anymore (the message and header aren't altered anymore to invalidate > the DKIM signatures). > > We (Jeff or anyone else with mailman admin privs) could use the same > settings for gcc-patches. The settings that need to be set are in that > bug: > > - subject_prefix (general): (empty) > - from_is_list (general): No > - anonymous_list (general): No > - first_strip_reply_to (general): No > - reply_goes_to_list (general): Poster > - reply_to_address (general): (empty) > - include_sender_header (general): No > - drop_cc (general): No > - msg_header (nondigest): (empty) > - msg_footer (nondigest): (empty) > - scrub_nondigest (nondigest): No > - dmarc_moderation_action (privacy): Accept > - filter_content (contentfilter): No > > The only visible change (apart from no more From rewriting) is that > HTML multi-parts aren't scrubbed anymore (that would be a message > altering issue). The html part is still scrubbed from the > inbox.sourceware.org archive, so b4 works just fine. But I don't know > what patchwork.sourceware.org does with HTML attachements. Of course > people really shouldn't sent HTML attachments to gcc-patches, so maybe > this is no real problem.
Ick (to the HTML part). I wonder if we can use From rewriting for those, still stripping the HTML part? Maybe we can also go back to rejecting mails that are not text/plain ... > Let me know if you want Jeff (or me or one of the other overseers) make > the above changes to the gcc-patches mailman settings. > > Cheers, > > Mark > > > [1] https://patchwork.sourceware.org/project/gcc/list/ > > [2] https://sourceware.org/bugzilla/show_bug.cgi?id=29713 >
