Hi! On Tue, Jun 13, 2023 at 10:15:49AM +0800, Jiufu Guo wrote: > David Edelsohn <dje....@gmail.com> writes: > > > > This definitely seems to be a better solution. > > > > The TARGET_CONST_ANCHOR change should not be part of this patch. Also > > there is no ChangeLog for the patch. > > Thanks a lot for your quick review!! And sorry for the sending this patch > in a hurry. I would update the patch accordingly.
> > This generally looks correct and consistent with other ports. I want > > to give Segher a chance to double check it, if he wishes. The documentation is very clear that the only thing for which you can have BLKmode is "mem". Not unspec, only "mem". Let's not do this. The existing code has clear and obvious semantics, which is documented as well -- there is no reason to make it worse in every respect! Segher
