The following fixes code GENERIC generation for (convert! ...)
which currently generates

  if (TREE_TYPE (_o1[0]) != type)
    _r1 = fold_build1_loc (loc, NOP_EXPR, type, _o1[0]);
    if (EXPR_P (_r1))
      goto next_after_fail867;
  else
    _r1 = _o1[0];

where obviously braces are missing.

Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed to trunk,
will push down to branches as well.

        PR middle-end/110200
        * genmatch.cc (expr::gen_transform): Put braces around
        the if arm for the (convert ...) short-cut.
---
 gcc/genmatch.cc | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gcc/genmatch.cc b/gcc/genmatch.cc
index bd6ce3a28f8..5fceeec9780 100644
--- a/gcc/genmatch.cc
+++ b/gcc/genmatch.cc
@@ -2625,7 +2625,8 @@ expr::gen_transform (FILE *f, int indent, const char 
*dest, bool gimple,
        {
          fprintf_indent (f, indent, "if (TREE_TYPE (_o%d[0]) != %s)\n",
                          depth, type);
-         indent += 2;
+         fprintf_indent (f, indent + 2, "{\n");
+         indent += 4;
        }
       if (opr->kind == id_base::CODE)
        fprintf_indent (f, indent, "_r%d = fold_build%d_loc (loc, %s, %s",
@@ -2648,7 +2649,8 @@ expr::gen_transform (FILE *f, int indent, const char 
*dest, bool gimple,
        }
       if (*opr == CONVERT_EXPR)
        {
-         indent -= 2;
+         fprintf_indent (f, indent - 2, "}\n");
+         indent -= 4;
          fprintf_indent (f, indent, "else\n");
          fprintf_indent (f, indent, "  _r%d = _o%d[0];\n", depth, depth);
        }
-- 
2.35.3

Reply via email to