On Mon, 23 Apr 2012, Jan Hubicka wrote: > Hi, > when building Mozilla we ICE in expr_invariant_in_loop_p walking ARRAY_REF, > because one of the > fields is NULL (that is allowed) > > Bootstrapped/regtested x86_64-linux, OK?
Ok with breaking the like before && - lines need to be less than 80 columns. Thanks, Richard. > Honza > > * tree-ssa-loop-ivopts.c (expr_invariant_in_loop_p): Bail out at NULL > tree refs. > Index: tree-ssa-loop-ivopts.c > =================================================================== > *** tree-ssa-loop-ivopts.c (revision 186688) > --- tree-ssa-loop-ivopts.c (working copy) > *************** expr_invariant_in_loop_p (struct loop *l > *** 1411,1417 **** > > len = TREE_OPERAND_LENGTH (expr); > for (i = 0; i < len; i++) > ! if (!expr_invariant_in_loop_p (loop, TREE_OPERAND (expr, i))) > return false; > > return true; > --- 1411,1417 ---- > > len = TREE_OPERAND_LENGTH (expr); > for (i = 0; i < len; i++) > ! if (TREE_OPERAND (expr, i) && !expr_invariant_in_loop_p (loop, > TREE_OPERAND (expr, i))) > return false; > > return true; > > -- Richard Guenther <rguent...@suse.de> SUSE / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer