Hello, Jonathan Wakely, le ven. 07 oct. 2022 12:14:26 +0100, a ecrit: > As documented at https://gcc.gnu.org/lists.html all patches for > libstdc++ need to be CC'd to the libstdc++ list. That's why your patch > has not been reviewed, because I didn't see it.
Ah, sorry, I hadn't noticed that. > On 29/08/22 02:30 +0200, Samuel Thibault wrote: > > This is notably needed because in glibc 2.34, the move of pthread functions > > into libc.so happened for Linux only, not GNU/Hurd. > > > > The pthread_self() function can also always be used fine as it is. > > > > libstdc++-v3/ChangeLog: > > > > > * config/os/gnu/os_defines.h: New file. > > * config/os/gnu/ctype_base.h: New file. > > * config/os/gnu/ctype_configure_char.cc: New file. > > * config/os/gnu/ctype_inline.h: New file. > > * configure.host: On gnu* host, use os/gnu instead of os/gnu-linux. > > I think the commit message should note that these files are all copied > from the existing gnu-linux ones, so that the git log records that and > people don't need to compare them manually. > > But if these files are all identical to the existing gnu-linux ones, > except for a couple of macros in os_defines.h being conditional on > Linux, why not just test __linux__ in os_defines.h? Ah, it's just that I hadn't seen that done for other OSes, even when they are very similar (e.g. between gnu-linux and uclibc). If #ifdef is fine there, then yes I'm all for it indeed. I'll send a v2. Samuel
