As documented at https://gcc.gnu.org/lists.html all patches for
libstdc++ need to be CC'd to the libstdc++ list. That's why your patch
has not been reviewed, because I didn't see it.
On 29/08/22 02:30 +0200, Samuel Thibault wrote:
This is notably needed because in glibc 2.34, the move of pthread functions
into libc.so happened for Linux only, not GNU/Hurd.
The pthread_self() function can also always be used fine as it is.
libstdc++-v3/ChangeLog:
* config/os/gnu/os_defines.h: New file.
* config/os/gnu/ctype_base.h: New file.
* config/os/gnu/ctype_configure_char.cc: New file.
* config/os/gnu/ctype_inline.h: New file.
* configure.host: On gnu* host, use os/gnu instead of os/gnu-linux.
I think the commit message should note that these files are all copied
from the existing gnu-linux ones, so that the git log records that and
people don't need to compare them manually.
But if these files are all identical to the existing gnu-linux ones,
except for a couple of macros in os_defines.h being conditional on
Linux, why not just test __linux__ in os_defines.h?
Do we need three new ctype files that are identical to existing files?
Why maintain two copies of the same code?
diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog
index ba5939d9003..dd288cce2ca 100644
--- a/libstdc++-v3/ChangeLog
+++ b/libstdc++-v3/ChangeLog
@@ -1,3 +1,11 @@
+2022-08-28 Samuel Thibault <samuel.thiba...@ens-lyon.org>
+
+ * config/os/gnu/os_defines.h: New file.
+ * config/os/gnu/ctype_base.h: New file.
+ * config/os/gnu/ctype_configure_char.cc: New file.
+ * config/os/gnu/ctype_inline.h: New file.
+ * configure.host: On gnu* host, use os/gnu instead of os/gnu-linux.
+
Please do not include ChangeLog diffs in the patch, it just means the
patch can't be applied cleanly. GCC changelogs are auto-generated
every night. The ChangeLog entry should be submitted as plain text not
inthe diff, or just make it part of your Git commit message.
https://gcc.gnu.org/contribute.html#patches
