On Thu, 23 Jun 2022 at 15:05, Alexandre Oliva <ol...@adacore.com> wrote: > > On Jun 23, 2022, Jonathan Wakely <jwak...@redhat.com> wrote: > > > On Thu, 23 Jun 2022 at 12:08, Alexandre Oliva <ol...@adacore.com> wrote: > >> > >> On Jun 22, 2022, Jonathan Wakely <jwak...@redhat.com> wrote: > >> > >> > There are other interactions between AT_CDCWD and ::openat not covered > >> > by this patch. I this this also needs to check HAVE_OPENAT: > >> > >> Here's an updated version, tested with this additional change. > > > Did this improve your test results for directory iterators? > > 'fraid the bad results I posted earlier today had this patch in. I
Ah, but this patch only added the HAVE_OPENAT check to src/filesystem/dir.cc not the similar code in src/c++17/fs_dir.cc So it only affected std::experimental::filesystem and I would expect the std::filesystem directory iterator tests to fail still. Nevermind, I'm going to make a change that resolves it anyway. > can't tell whether it improved anything because I didn't save earlier > results to compare. > > > In the unlikely even that the target has ::unlinkat but not ::openat > > c++config.h on the target says: > > /* #undef _GLIBCXX_HAVE_UNLINKAT */ > > Thanks for the concern, > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > Disinformation flourishes because many people care deeply about injustice > but very few check the facts. Ask me about <https://stallmansupport.org> >
