> This patch (for 4.6) fixes a wrong subword index computation in > store_bit_field_1 for big endian targets when value is at least 4 times > bigger than a word (DI REG value with HI words). > > It fixes a regression on gcc.c-torture/execute/bitfld-3.c for my current > backend port. > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51893 > > OK to commit?
It is OK for mainline on principle but there is no ChangeLog entry and the patch doesn't follow the GNU Coding Style: TABs instead of spaces, spaces before parentheses, etc. See the equivalent code in extract_bit_field_1. Moreover you need to properly test it on a mainstream big-endian platform. See http://gcc.gnu.org/contribute.html for a more complete reference. -- Eric Botcazou
