On 12/10/2021 5:56 AM, Jakub Jelinek wrote:
On Thu, Dec 09, 2021 at 05:59:54PM +0100, Jakub Jelinek via Gcc-patches wrote:/tmp/6140018_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/config/aarch64/aarch64-sve-builtins.cc:3920:0: ./gt-aarch64-sve-builtins.h: In function 'void gt_pch_p_19registered_function(void*, void*, gt_pointer_operator, void*)': ./gt-aarch64-sve-builtins.h:86:44: error: no matching function for call to 'gt_pch_nx(aarch64_sve::function_instance*, void (*&)(void*, void*, void*), void*&)' gt_pch_nx (&((*x).instance), op, cookie);Fixed thusly, compile tested on x86_64-linux, committed to trunk.Here is a small cleanup. IMHO we should use gt_pointer_operator instead of specifying manually void (*) (void *, void *) or void (*) (void *, void *, void *) so that next time we want to change it, we don't have to trace all the spots. I was afraid it wouldn't work due to header dependencies, but it works well. gengtype generated files also use gt_pointer_operator. Ok for trunk (tested on x86_64-linux and cross to aarch64-linux)? 2021-12-10 Jakub Jelinek <ja...@redhat.com> * machmode.h (gt_pch_nx): Use gt_pointer_operator as type of second argument instead of equivalent void (*) (void *, void *, void *). * poly-int.h (gt_pch_nx): Likewise. * wide-int.h (gt_pch_nx): Likewise. * config/aarch64/aarch64-sve-builtins.cc (gt_pch_nx): Likewise.
OK jeff
