Hi, On Fri, Dec 03, 2021 at 06:58:36AM +1100, Nicholas Nethercote wrote: > On Fri, 3 Dec 2021 at 04:17, Mark Wielaard <m...@klomp.org> wrote: > > > > * rust-demangle.c (rust_demangle_callback): Ignore everything > > after '.' char in sym for v0. > > > > I just applied this change to Valgrind's copy of rust-demangle.c and I can > confirm that it works -- the symbols that were failing to be demangled are > now demangled.
Thanks for testing. > > + /* Rust v0 symbols can have '.' suffixes, ignore those. */ > > + if (rdm.version == 0 && *p == '.') > > + break; > > > > Note that the indent on the `break` is 1 char, it should be 2. Oops. That is actually because I used a tab for indentation, but this file doesn't use tabs. Fixed in my local copy https://code.wildebeest.org/git/user/mjw/gcc/commit/?h=rust-demangle-suffix Will push with that fix if approved. Thanks, Mark
