On 9/28/21 16:20, Marek Polacek wrote:
On Thu, Sep 23, 2021 at 02:25:16PM -0400, Jason Merrill wrote:
On 9/20/21 18:59, Marek Polacek via Gcc-patches wrote:
+ handle_ignored_attributes_option (&v);
+ /* ??? We can't free (args); here. */
Perhaps we want to copy strings in handle_ignored_attributes_option rather
than here?
Well, the other use doesn't need copying, so I left it be.
But the other use is modifying the strings passed on the command line,
which also seems questionable. I think it would be better for
handle_ignored_attributes_option to copy the relevant pieces out.
The patch looks good outside of this issue.
Jason
