Hi Jeff, On Tue, 2021-10-05 08:53:00 -0600, Jeff Law <[email protected]> wrote: > On 10/5/2021 8:46 AM, Jan-Benedict Glaw wrote: > > On Thu, 2021-09-30 21:27:23 +0200, Jan-Benedict Glaw <[email protected]> > > wrote: > > > gcc/ChangeLog: > > > > > > * common/config/avr/avr-common.c (avr_handle_option): Mark > > > argument as ATTRIBUTE_UNUSED. > > > > > > diff --git a/gcc/common/config/avr/avr-common.c > > > b/gcc/common/config/avr/avr-common.c > > > index 6486659d27c..a6939ad03d3 100644 > > > --- a/gcc/common/config/avr/avr-common.c > > > +++ b/gcc/common/config/avr/avr-common.c > > > @@ -77,7 +77,8 @@ static const struct default_options > > > avr_option_optimization_table[] = > > > static bool > > > avr_handle_option (struct gcc_options *opts, struct gcc_options*, > > > - const struct cl_decoded_option *decoded, location_t > > > loc) > > > + const struct cl_decoded_option *decoded, > > > + location_t loc ATTRIBUTE_UNUSED) > > > { > > > int value = decoded->value; > > > > > > > > > Ok for trunk? > > Wanted to give this a ping. > I thought I sent a reply a few days ago. Instead of using ATTRIBUTE_UNUSED, > just drop the parameter's name. You should consider that pre-approved for > this and any other cases you run into.
Not quite I think. The `loc`ation parameter is used under some
circumstances, though it's dependant on some #ifdefs:
78 static bool
79 avr_handle_option (struct gcc_options *opts, struct gcc_options*,
80 const struct cl_decoded_option *decoded,
81 location_t loc ATTRIBUTE_UNUSED)
82 {
83 int value = decoded->value;
84
85 switch (decoded->opt_index)
86 {
87 case OPT_mdouble_:
88 if (value == 64)
89 {
90 #if !defined (HAVE_DOUBLE64)
91 error_at (loc, "option %<-mdouble=64%> is only available if "
92 "configured %<--with-double={64|64,32|32,64}%>");
93 #endif
94 opts->x_avr_long_double = 64;
95 }
96 else if (value == 32)
97 {
98 #if !defined (HAVE_DOUBLE32)
99 error_at (loc, "option %<-mdouble=32%> is only available if "
100 "configured %<--with-double={32|32,64|64,32}%>");
101 #endif
102 }
Also, this implements the TARGET_HANDLE_OPTION function, so changing
the arguments wouldn't really work and as the `loc` argument is used
under certain circumstances, I kept it as is and marked it unused.
(Adding an #ifdef in front doesn't make the code any more readable.)
Thanks,
Jan-Benedict
--
signature.asc
Description: PGP signature
